Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci][tests-only] Add internal link e2e tests for project space #8361

Merged
merged 3 commits into from
Feb 8, 2023
Merged

[full-ci][tests-only] Add internal link e2e tests for project space #8361

merged 3 commits into from
Feb 8, 2023

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Feb 3, 2023

Description

Added internal link e2e test journey for the project space

Related Issue

Part of #8101

Motivation and Context

How Has This Been Tested?

local

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan added the QA:team label Feb 3, 2023
@saw-jan saw-jan self-assigned this Feb 3, 2023
This was referenced Feb 3, 2023
Merged
Closed
@saw-jan saw-jan marked this pull request as ready for review February 3, 2023 10:57
@saw-jan saw-jan force-pushed the tests/internalLink-spaces branch 2 times, most recently from 645d1c3 to 260fef7 Compare February 6, 2023 03:45
SagarGi
SagarGi reviewed Feb 6, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SagarGi SagarGi requested a review from ScharfViktor February 6, 2023 10:05
@saw-jan saw-jan force-pushed the tests/internalLink-spaces branch from 260fef7 to 5c046e2 Compare February 7, 2023 06:53
SwikritiT
SwikritiT approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ScharfViktor ScharfViktor self-requested a review February 7, 2023 12:01
ScharfViktor
ScharfViktor approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than what I wrote earlier everything else is cool, thanks

amrita-shrestha
amrita-shrestha reviewed Feb 7, 2023
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than existing comment lgtm

@saw-jan saw-jan force-pushed the tests/internalLink-spaces branch from 5c046e2 to fa9009e Compare February 8, 2023 06:56
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saw-jan saw-jan merged commit 3a5895d into stable-6.0 Feb 8, 2023
@delete-merged-branch delete-merged-branch bot deleted the tests/internalLink-spaces branch February 8, 2023 08:42
@saw-jan saw-jan mentioned this pull request Feb 8, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrita-shrestha amrita-shrestha amrita-shrestha left review comments

@SagarGi SagarGi SagarGi left review comments

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@SwikritiT SwikritiT SwikritiT approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@saw-jan @SwikritiT @SagarGi @amrita-shrestha @ScharfViktor